cannon: use constant instead of magic value#12386
Merged
Inphi merged 4 commits intoethereum-optimism:developfrom Oct 16, 2024
Merged
cannon: use constant instead of magic value#12386Inphi merged 4 commits intoethereum-optimism:developfrom
Inphi merged 4 commits intoethereum-optimism:developfrom
Conversation
zhiqiangxu
force-pushed
the
calling_convention
branch
from
9ef1b5e to
35f5d25
Compare
zhiqiangxu
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #12386 +/- ##
===========================================
- Coverage 64.32% 64.14% -0.19%
===========================================
Files 52 52
Lines 4348 4348
===========================================
- Hits 2797 2789 -8
- Misses 1376 1385 +9
+ Partials 175 174 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mbaxter
reviewed
Oct 11, 2024
zhiqiangxu
force-pushed
the
calling_convention
branch
from
509fa7d to
9bdfb1c
Compare
zhiqiangxu
force-pushed
the
calling_convention
branch
from
9bdfb1c to
97f412b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does 2 things:
Gradually we should shift to these constant names and stop using magic numbers.